linux-kernel - Re: [PATCH] rtc: max77686: Remove some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f34ebcd-0c17-cd7f-eb08-52c6c3dc7b03@wanadoo.fr>
Date:   Sat, 8 May 2021 18:59:25 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Edmundo Carmona Antoranz <eantoranz@...il.com>
Cc:     cw00.choi@...sung.com, krzysztof.kozlowski@...onical.com,
        b.zolnierkie@...sung.com, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] rtc: max77686: Remove some dead code

Le 08/05/2021 à 16:38, Edmundo Carmona Antoranz a écrit :
> On Fri, May 7, 2021 at 11:43 PM Christophe JAILLET
> <christophe.jaillet@...adoo.fr> wrote:
>>          if (IS_ERR(info->rtc_dev)) {
>>                  ret = PTR_ERR(info->rtc_dev);
>>                  dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
> 
> Following the recent conversations, I think it might make sense to do
> dev_err(&pdev->dev, "Failed to register RTC device: %pe\n", info->rtc_dev);
> 
> Is that right?
> 

Yes, it is right, but it should be done in another patch.

Would you like to give it a try?

CJ