linux-kernel - Re: [PATCH] RDMA/mlx4: Remove unnessesary check in mlx4_ib_modify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 9 May 2021 12:40:21 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     yishaih@...dia.com, dledford@...hat.com, jgg@...pe.ca,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/mlx4: Remove unnessesary check in
 mlx4_ib_modify_wq()

On Fri, May 07, 2021 at 06:22:41PM +0800, Jiapeng Chong wrote:
> cur_state and new_state are enums and when GCC considers
> them as unsigned, the conditions are never met.
> 
> Clean up the following smatch warning:
> 
> drivers/infiniband/hw/mlx4/qp.c:4258 mlx4_ib_modify_wq() warn: unsigned
> 'cur_state' is never less than zero.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/infiniband/hw/mlx4/qp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c
> index 92ddbcc..162aa59 100644
> --- a/drivers/infiniband/hw/mlx4/qp.c
> +++ b/drivers/infiniband/hw/mlx4/qp.c
> @@ -4255,8 +4255,7 @@ int mlx4_ib_modify_wq(struct ib_wq *ibwq, struct ib_wq_attr *wq_attr,
>  						     ibwq->state;
>  	new_state = wq_attr_mask & IB_WQ_STATE ? wq_attr->wq_state : cur_state;
>  
> -	if (cur_state  < IB_WQS_RESET || cur_state  > IB_WQS_ERR ||
> -	    new_state < IB_WQS_RESET || new_state > IB_WQS_ERR)
> +	if (cur_state > IB_WQS_ERR || new_state > IB_WQS_ERR)
>  		return -EINVAL;

Actually the more robust change will be to move this change to the ib_uverbs_ex_modify_wq().

Thanks

>  
>  	if ((new_state == IB_WQS_RDY) && (cur_state == IB_WQS_ERR))
> -- 
> 1.8.3.1
>