linux-kernel - Re: [PATCH v1] brcmfmac: Silence error messages about unsupported firmware features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <34330b8c-1c9d-de77-8f7f-4400855777fb@gmail.com>
Date:   Tue, 11 May 2021 01:24:23 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Arend van Spriel <arend.vanspriel@...adcom.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
        Wright Feng <wright.feng@...ress.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "brcm80211-dev-list.pdl@...adcom.com" 
        <brcm80211-dev-list.pdl@...adcom.com>,
        "brcm80211-dev-list@...ress.com" <brcm80211-dev-list@...ress.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] brcmfmac: Silence error messages about unsupported
 firmware features

11.05.2021 01:18, Andy Shevchenko пишет:
> On Tuesday, May 11, 2021, Dmitry Osipenko <digetx@...il.com
> <mailto:digetx@...il.com>> wrote:
> 
>     KMSG is flooded with error messages about unsupported firmware
>     features on BCM4329 chip. The GET_ASSOCLIST error became especially
>     noisy with a newer NetworkManager version of Ubuntu 21.04. Let's print
>     the noisy error messages only once.
> 
> 
> Seems like you are reinventing *_once() printing methods. Please use
> them instead

Indeed, I see now that it won't be difficult to add the new
wiphy_err_once() helper that will use the generic dev_err_once(). I'll
make a v2, thank you for taking a look at the patch.