linux-kernel - RE: [PATCH v6 00/13] Add build ID to stacktraces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com>
Date:   Tue, 11 May 2021 12:58:47 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Steven Rostedt' <rostedt@...dmis.org>
CC:     'Stephen Boyd' <swboyd@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Petr Mladek <pmladek@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Alexei Starovoitov" <ast@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Baoquan He <bhe@...hat.com>, "Borislav Petkov" <bp@...en8.de>,
        Catalin Marinas <catalin.marinas@....com>,
        Dave Young <dyoung@...hat.com>,
        Evan Green <evgreen@...omium.org>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Ingo Molnar <mingo@...hat.com>, Jessica Yu <jeyu@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
        Konstantin Khlebnikov <khlebnikov@...dex-team.ru>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>,
        "Rasmus Villemoes" <linux@...musvillemoes.dk>,
        Sasha Levin <sashal@...nel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vivek Goyal <vgoyal@...hat.com>, Will Deacon <will@...nel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        Christoph Hellwig <hch@...radead.org>,
        peter enderborg <peter.enderborg@...y.com>
Subject: RE: [PATCH v6 00/13] Add build ID to stacktraces

From: Steven Rostedt
> Sent: 11 May 2021 13:53
> 
> On Tue, 11 May 2021 12:36:06 +0000
> David Laight <David.Laight@...LAB.COM> wrote:
> 
> > >  x1 : ffffff93fef15788 x0 : ffffffe3622352e0
> > >  Call trace:
> > >   lkdtm_WARNING+0x28/0x30 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e]
> > >   direct_entry+0x16c/0x1b4 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e]
> > >   full_proxy_write+0x74/0xa4
> >
> > Is there any way to get it to print each module ID only once?
> 
> If there's a trivial way to do that, then perhaps it should be done, but for
> now, this patch series isn't as obnoxious as the previous versions. It only
> affects stack traces, and I'm fine with that.

True. Printing the id in the module list was horrid.

The real downside is all the extra text that will overflow the
in-kernel buffer.
At least it shouldn't be extra lines causing screen wrap.
Unless the variable names are long - hi rust :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)