linux-kernel - Re: [PATCH 4/6] x86/irq: merge common code in DEFINE_IDTENTRY_SYSVEC[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35c78aaa-4621-6a32-5c53-c2680a4b66c5@zytor.com>
Date:   Wed, 12 May 2021 11:00:54 -0700
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Andy Lutomirski <luto@...nel.org>,
        Steve Wahl <steve.wahl@....com>,
        Mike Travis <mike.travis@....com>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Russ Anderson <russ.anderson@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/6] x86/irq: merge common code in
 DEFINE_IDTENTRY_SYSVEC[_SIMPLE]



On 5/12/21 1:38 AM, Ingo Molnar wrote:
> 
> * H. Peter Anvin <hpa@...or.com> wrote:
> 
>> On 5/11/21 7:22 AM, Thomas Gleixner wrote:
>>>
>>> That's not really making the code more readable. Something like the
>>> below perhaps?
>>>
>>> #define IDTENTRY_INVOKE_SYSVEC(func, regs, raw)				\
>>> do {									\
>>> 	irqentry_state_t state = irqentry_enter(regs);			\
>>> 									\
>>> 	instrumentation_begin();					\
>>> 	kvm_set_cpu_l1tf_flush_l1d();					\
>>>           if (raw) {							\
>>> 		__irq_enter_raw();					\
>>> 		func(regs);						\
>>> 		__irq_exit_raw();			                \
>>> 	} else {	                                                \
>>> 		run_sysvec_on_irqstack_cond(func, regs);	        \
>>>           }                                                               \
>>> 	instrumentation_end();						\
>>>           irqentry_exit(regs, state);					\
>>> } while (0)								\
>>>
>>
>> Digging more into it, it looks like a *lot* of the macros in
>> <asm/irq_stack.h> and <asm/idtentry.h> can be replaced with inlines without
>> any change in functionality or generated code.
> 
> That would be a much preferred outcome ...

Well, here is an RFC. This is obviously a much bigger change and I don't 
feel it is mature yet, but it would be good to know if you (plural) feel 
it is in the right direction.

I will clean up the rest of the patchset and resubmit.

	-hpa


View attachment "0001-x86-irq-merge-and-functionalize-common-code-in-DECLA.patch" of type "text/x-patch" (17744 bytes)