linux-kernel - Re: [RFC v2 PATCH 7/7] x86/entry: use int for syscall number; handle all invalid syscall nrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60495dd3-ea68-4db3-47ad-b7b45796bf76@zytor.com>
Date:   Wed, 12 May 2021 11:21:38 -0700
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Andy Lutomirski <luto@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC v2 PATCH 7/7] x86/entry: use int for syscall number; handle
 all invalid syscall nrs

On 5/12/21 5:09 AM, Thomas Gleixner wrote:
> 
>> index 1d9db15fdc69..85f04ea0e368 100644
>> --- a/arch/x86/entry/entry_64.S
>> +++ b/arch/x86/entry/entry_64.S
>> @@ -108,7 +108,7 @@ SYM_INNER_LABEL(entry_SYSCALL_64_after_hwframe, SYM_L_GLOBAL)
>>   
>>   	/* IRQs are off. */
>>   	movq	%rsp, %rdi
>> -	movq	%rax, %rsi
>> +	movslq	%eax, %rsi
> 
> This is wrong.
> 
>    syscall(long number,...);
> 
> So the above turns syscall(UINT_MAX + N, ...) into syscall(N, ...).
> 

That is intentional, as (again) system calls are int. As stated in my 
reply to Ingo, I'll clean the various descriptions and try to capture 
the discussion better.

	-hpa