linux-kernel - Re: [PATCH -next] gpio: cadence: Add missing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJX2dt1=_yW14df5tpEiRN0_LAgLdamNx+3d==CRxM6s8w@mail.gmail.com>
Date:   Wed, 12 May 2021 13:28:49 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] gpio: cadence: Add missing MODULE_DEVICE_TABLE

On Wed, May 12, 2021 at 5:01 AM Zou Wei <zou_wei@...wei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/gpio/gpio-cadence.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-cadence.c b/drivers/gpio/gpio-cadence.c
> index a4d3239..4ab3fcd 100644
> --- a/drivers/gpio/gpio-cadence.c
> +++ b/drivers/gpio/gpio-cadence.c
> @@ -278,6 +278,7 @@ static const struct of_device_id cdns_of_ids[] = {
>         { .compatible = "cdns,gpio-r1p02" },
>         { /* sentinel */ },
>  };
> +MODULE_DEVICE_TABLE(of, cdns_of_ids);
>
>  static struct platform_driver cdns_gpio_driver = {
>         .driver = {
> --
> 2.6.2
>

The tag should be just regular [PATCH] as this driver has been
upstream for a long time.

Applied for fixes, thanks!

Bartosz