linux-kernel - Re: [PATCH RESEND] ARM: dts: imx6dl-yapp4: Fix RGMII connection to QCA8334 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5DH3FLXbX5RTRY_gM3uJ8MY=q6ovSOh5L3vD03YGPgDYA@mail.gmail.com>
Date:   Wed, 12 May 2021 10:23:33 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Michal Vokáč <michal.vokac@...ft.com>
Cc:     Shawn Guo <shawnguo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH RESEND] ARM: dts: imx6dl-yapp4: Fix RGMII connection to
 QCA8334 switch

On Wed, May 12, 2021 at 6:56 AM Michal Vokáč <michal.vokac@...ft.com> wrote:
>
> The FEC does not have a PHY so it should not have a phy-handle. It is
> connected to the switch at RGMII level so we need a fixed-link sub-node
> on both ends.
>
> This was not a problem until the qca8k.c driver was converted to PHYLINK
> by commit b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of
> PHYLIB"). That commit revealed the FEC configuration was not correct.
>
> Fixes: 87489ec3a77f ("ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards")
> Cc: stable@...r.kernel.org
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>

Reviewed-by: Fabio Estevam <festevam@...il.com>