linux-kernel - Re: [PATCH net-next v4 2/4] page_pool: Allow drivers to hint on SKB recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 May 2021 16:09:47 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Ilias Apalodimas <ilias.apalodimas@...aro.org>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Matteo Croce <mcroce@...ux.microsoft.com>,
        netdev <netdev@...r.kernel.org>, linux-mm <linux-mm@...ck.org>,
        Ayush Sawal <ayush.sawal@...lsio.com>,
        Vinay Kumar Yadav <vinay.yadav@...lsio.com>,
        Rohit Maheshwari <rohitm@...lsio.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Russell King <linux@...linux.org.uk>,
        Mirko Lindner <mlindner@...vell.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        Boris Pismenny <borisp@...dia.com>,
        Arnd Bergmann <arnd@...db.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Vlastimil Babka <vbabka@...e.cz>, Yu Zhao <yuzhao@...gle.com>,
        Will Deacon <will@...nel.org>,
        Michel Lespinasse <walken@...gle.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Roman Gushchin <guro@...com>, Hugh Dickins <hughd@...gle.com>,
        Peter Xu <peterx@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Alexander Lobakin <alobakin@...me>,
        Cong Wang <cong.wang@...edance.com>, wenxu <wenxu@...oud.cn>,
        Kevin Hao <haokexin@...il.com>,
        Jakub Sitnicki <jakub@...udflare.com>,
        Marco Elver <elver@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Yunsheng Lin <linyunsheng@...wei.com>,
        Guillaume Nault <gnault@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Matthew Wilcox <willy@...radead.org>,
        David Ahern <dsahern@...il.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Saeed Mahameed <saeedm@...dia.com>,
        Andrew Lunn <andrew@...n.ch>, Paolo Abeni <pabeni@...hat.com>,
        Sven Auhagen <sven.auhagen@...eatech.de>
Subject: Re: [PATCH net-next v4 2/4] page_pool: Allow drivers to hint on SKB recycling

On Wed, May 12, 2021 at 11:50 AM Ilias Apalodimas
<ilias.apalodimas@...aro.org> wrote:
>
> [...]
> > > Since we added an extra argument on __skb_frag_unref() to handle
> > > recycling, update the current users of the function with that.
> >
> > This part could be done with a preliminary patch, only adding this
> > extra boolean, this would keep the 'complex' patch smaller.
>
> Sure
>
> [...]
> > >  #include <linux/uaccess.h>
> > >  #include <trace/events/skb.h>
> > > @@ -645,6 +648,11 @@ static void skb_free_head(struct sk_buff *skb)
> > >  {
> > >     unsigned char *head = skb->head;
> > >
> > > +#if IS_BUILTIN(CONFIG_PAGE_POOL)
> >
> > Why IS_BUILTIN() ?
>
> No reason, we'll replace it with an ifdef
>
> >
> > PAGE_POOL is either y or n
> >
> > IS_ENABLED() would look better, since we use IS_BUILTIN() for the cases where a module might be used.
> >
> > Or simply #ifdef CONFIG_PAGE_POOL
> >
> > > +   if (skb->pp_recycle && page_pool_return_skb_page(head))
> >
> > This probably should be attempted only in the (skb->head_frag) case ?
>
> I think the extra check makes sense.

What do you mean here ?

>
> >
> > Also this patch misses pskb_expand_head()
>
> I am not sure I am following. Misses what? pskb_expand_head() will either
> call skb_release_data() or skb_free_head(), which would either recycle or
> unmap the buffer for us (depending on the page refcnt)

 pskb_expand_head() allocates a new skb->head, from slab.

We should clear skb->pp_recycle for consistency of the skb->head_frag
clearing we perform there.

But then, I now realize you use skb->pp_recycle bit for both skb->head
and fragments,
and rely on this PP_SIGNATURE thing (I note that patch 1 changelog
does not describe why a random page will _not_ have this signature by
bad luck)

Please document/describe which struct page fields are aliased with
page->signature ?

Thanks !