linux-kernel - Re: [PATCH v7 1/5] usb: dwc3: host: Set PHY mode during suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wns27nlq.fsf@kernel.org>
Date:   Thu, 13 May 2021 16:46:41 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Sandeep Maheswaram <sanm@...eaurora.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Doug Anderson <dianders@...omium.org>,
        linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, Manu Gautam <mgautam@...eaurora.org>
Subject: Re: [PATCH v7 1/5] usb: dwc3: host: Set PHY mode during suspend


Hi,

Matthias Kaehlcke <mka@...omium.org> writes:
>> > @@ -127,6 +142,50 @@ int dwc3_host_init(struct dwc3 *dwc)
>> >  	return ret;
>> >  }
>> >  
>> > +static void dwc3_set_phy_mode(struct usb_hcd *hcd)
>> > +{
>> > +
>> > +	int i, num_ports;
>> > +	u32 reg;
>> > +	unsigned int ss_phy_mode = 0;
>> > +	struct dwc3 *dwc = dev_get_drvdata(hcd->self.controller->parent);
>> > +	struct xhci_hcd	*xhci_hcd = hcd_to_xhci(hcd);
>> > +
>> > +	dwc->hs_phy_mode = 0;
>> > +
>> > +	reg = readl(&xhci_hcd->cap_regs->hcs_params1);
>> > +	num_ports = HCS_MAX_PORTS(reg);
>> 
>> there's a big assumption here that xhci is still alive. Why isn't this
>> quirk implemented in xhci-plat itself?
>
> That should work for determining which types of devices are connected to
> the PHYs, however IIUC the xhci-plat doesn't know about the PHY topology.
> Are you suggesting to move that info into the xhci-plat driver so that it
> can set the corresponding PHY modes?

Yes, if xHCI needs to know about PHYs in order to properly configure the
PHYs, so be it :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (512 bytes)