linux-kernel - Re: [PATCH][next] drm: simpledrm: Fix use after free issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b709552-cd8c-0885-c99c-7cb9e2af905b@suse.de>
Date:   Thu, 13 May 2021 16:01:51 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Colin King <colin.king@...onical.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxime Ripard <maxime@...no.tech>,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm: simpledrm: Fix use after free issues

Hi

Am 12.05.21 um 22:30 schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There are two occurrances where objects are being free'd via
> a put call and yet they are being referenced after this. Fix these
> by adding in the missing continue statement so that the put on the
> end of the loop is skipped over.
> 
> Addresses-Coverity: ("Use after free")
> Fixes: 11e8f5fd223b ("drm: Add simpledrm driver")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Queued up for drm-misc-next. Thanks!

Best regards
Thomas

> ---
>   drivers/gpu/drm/tiny/simpledrm.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
> index 2bdb477d9326..eae748394b00 100644
> --- a/drivers/gpu/drm/tiny/simpledrm.c
> +++ b/drivers/gpu/drm/tiny/simpledrm.c
> @@ -298,6 +298,7 @@ static int simpledrm_device_init_clocks(struct simpledrm_device *sdev)
>   			drm_err(dev, "failed to enable clock %u: %d\n",
>   				i, ret);
>   			clk_put(clock);
> +			continue;
>   		}
>   		sdev->clks[i] = clock;
>   	}
> @@ -415,6 +416,7 @@ static int simpledrm_device_init_regulators(struct simpledrm_device *sdev)
>   			drm_err(dev, "failed to enable regulator %u: %d\n",
>   				i, ret);
>   			regulator_put(regulator);
> +			continue;
>   		}
>   
>   		sdev->regulators[i++] = regulator;
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)