linux-kernel - [PATCH] Unnecessary code change in spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 May 2021 11:33:07 +0900
From:   Chanwoo Lee <cw9316.lee@...sung.com>
To:     adrian.hunter@...el.com, riteshh@...eaurora.org,
        asutoshd@...eaurora.org, ulf.hansson@...aro.org,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     grant.jung@...sung.com, jt77.jang@...sung.com,
        dh0421.hwang@...sung.com, sh043.lee@...sung.com,
        cw9316.lee@...sung.com
Subject: [PATCH] Unnecessary code change in spin_lock section.

From: ChanWoo Lee <cw9316.lee@...sung.com>

This is the spin_lock section for cq_host, and mmc setting is unnecessary.

Signed-off-by: ChanWoo Lee <cw9316.lee@...sung.com>
---
 drivers/mmc/host/cqhci-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
index 93b0432bb601..4d76c858d45f 100644
--- a/drivers/mmc/host/cqhci-core.c
+++ b/drivers/mmc/host/cqhci-core.c
@@ -1090,8 +1090,8 @@ static void cqhci_recovery_finish(struct mmc_host *mmc)
 	spin_lock_irqsave(&cq_host->lock, flags);
 	cq_host->qcnt = 0;
 	cq_host->recovery_halt = false;
-	mmc->cqe_on = false;
 	spin_unlock_irqrestore(&cq_host->lock, flags);
+	mmc->cqe_on = false;
 
 	/* Ensure all writes are done before interrupts are re-enabled */
 	wmb();
-- 
2.29.0