[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210513171855.4bbeca6b@jic23-huawei>
Date: Thu, 13 May 2021 17:18:55 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Stephan Gerhold <stephan@...hold.net>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
Rob Herring <robh+dt@...nel.org>,
Robert Yang <decatf@...il.com>, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Michał Mirosław
<mirq-linux@...e.qmqm.pl>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
~postmarketos/upstreaming@...ts.sr.ht,
Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v2 0/3] iio: accel: kxcjk-1013: Add support for
KX023-1025
On Tue, 11 May 2021 16:23:59 +0200
Stephan Gerhold <stephan@...hold.net> wrote:
> KX023-1025 [1] is another accelerometer from Kionix that has lots
> of additional functionality compared to KXCJK-1013. It combines the
> motion interrupt functionality from KXCJK with the tap detection
> from KXTF9, plus a lot more other functionality.
>
> This patch set does not add support for any of the extra functionality,
> but makes basic functionality work with the existing kxcjk-1013 driver.
>
> At first, the register map for the KX023-1025 seems quite different
> from the other accelerometers supported by the kxcjk-1013.
> However, it turns out that at least most of the register bits
> still mean the same for KX023-1025.
>
> This patch set refactors the kxcjk-1013 driver a little bit
> to get the register addresses from a chip-specific struct.
> The register bits can be re-used for all the different chips.
>
> The KX023-1025 is used in several smartphones from Huawei.
> I tested these changes on a Huawei Ascend G7, someone else reported
> they also work fine on the Huawei Honor 5X (codename "kiwi").
>
> [1]: https://kionixfs.azureedge.net/en/datasheet/KX023-1025%20Specifications%20Rev%2012.0.pdf
Series applied to the togreg branch of iio.git and pushed out as testing
for the bots to see if they can find anything we missed.
Thanks,
Jonathan
> ---
> Changes in v2:
> - Make register structs static (reported by kernel test robot)
>
> Stephan Gerhold (3):
> dt-bindings: iio: kionix,kxcjk1013: Document kionix,kx023-1025
> iio: accel: kxcjk-1013: Refactor configuration registers into struct
> iio: accel: kxcjk-1013: Add support for KX023-1025
>
> .../bindings/iio/accel/kionix,kxcjk1013.yaml | 1 +
> drivers/iio/accel/kxcjk-1013.c | 217 ++++++++++++++----
> 2 files changed, 176 insertions(+), 42 deletions(-)
>
Powered by blists - more mailing lists