linux-kernel - Re: [PATCH] serial: kgdb_nmi: remove redundant initialization of variable c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea469561-4103-4fd9-2c53-30d3e797e16d@kernel.org>
Date:   Fri, 14 May 2021 08:51:57 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Colin King <colin.king@...onical.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: kgdb_nmi: remove redundant initialization of
 variable c

On 14. 05. 21, 1:02, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable c is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> ---
>   drivers/tty/serial/kgdb_nmi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c
> index db059b66438e..7e07ee915f3f 100644
> --- a/drivers/tty/serial/kgdb_nmi.c
> +++ b/drivers/tty/serial/kgdb_nmi.c
> @@ -115,7 +115,7 @@ static void kgdb_tty_recv(int ch)
>   static int kgdb_nmi_poll_one_knock(void)
>   {
>   	static int n;
> -	int c = -1;
> +	int c;
>   	const char *magic = kgdb_nmi_magic;
>   	size_t m = strlen(magic);
>   	bool printch = false;
> 


-- 
js
suse labs