linux-kernel - Re: [PATCH -next] buildid: fix build when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE-0n52mEv36FceSSC+DuWmXroVqubSwQKrgHNGhmawePtxkQQ@mail.gmail.com>
Date:   Fri, 14 May 2021 01:54:36 -0500
From:   Stephen Boyd <swboyd@...omium.org>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] buildid: fix build when CONFIG_MODULES is not set

Quoting Randy Dunlap (2021-05-13 10:15:10)
> Omit the static_assert() when CONFIG_MODULES is not set/enabled.
> Fixes these build errors:
>
> ../kernel/kallsyms.c: In function ‘__sprint_symbol’:
> ../include/linux/kernel.h:53:43: error: dereferencing pointer to incomplete type ‘struct module’
>  #define typeof_member(T, m) typeof(((T*)0)->m)
>                                            ^
> ../include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(typeof_member(struct module, build_id)) == 20"
>  #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>                                          ^
> ../kernel/kallsyms.c:454:4: note: in expansion of macro ‘static_assert’
>     static_assert(sizeof(typeof_member(struct module, build_id)) == 20);
>     ^~~~~~~~~~~~~
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Stephen Boyd <swboyd@...omium.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>

Thanks. I didn't realize that there was an ifdef around the definition
of 'struct module'.