linux-kernel - Re: [PATCH 05/33] locking/atomic: openrisc: avoid asm-generic/atomic.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210514101741.GA30645@C02TD0UTHF1T.local>
Date:   Fri, 14 May 2021 11:17:41 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Stafford Horne <shorne@...il.com>
Cc:     linux-kernel@...r.kernel.org, will@...nel.org,
        boqun.feng@...il.com, peterz@...radead.org, aou@...s.berkeley.edu,
        arnd@...db.de, bcain@...eaurora.org, benh@...nel.crashing.org,
        chris@...kel.net, dalias@...c.org, davem@...emloft.net,
        deanbo422@...il.com, deller@....de, geert@...ux-m68k.org,
        green.hu@...il.com, guoren@...nel.org, ink@...assic.park.msu.ru,
        James.Bottomley@...senpartnership.com, jcmvbkbc@...il.com,
        jonas@...thpole.se, ley.foon.tan@...el.com, linux@...linux.org.uk,
        mattst88@...il.com, monstr@...str.eu, mpe@...erman.id.au,
        nickhu@...estech.com, palmer@...belt.com, paulus@...ba.org,
        paul.walmsley@...ive.com, rth@...ddle.net,
        stefan.kristiansson@...nalahti.fi, tsbogend@...ha.franken.de,
        vgupta@...opsys.com, ysato@...rs.sourceforge.jp
Subject: Re: [PATCH 05/33] locking/atomic: openrisc: avoid
 asm-generic/atomic.h

On Fri, May 14, 2021 at 06:44:25AM +0900, Stafford Horne wrote:
> On Mon, May 10, 2021 at 10:37:25AM +0100, Mark Rutland wrote:
> > OpenRISC is the only architecture which uses asm-generic/atomic.h and
> > also provides its own implementation of some functions, requiring
> > ifdeferry in the asm-generic header. As OpenRISC provides the vast
> > majority of functions itself, it would be simpler overall if it also
> > provided the few functions it cribs from asm-generic.
> > 
> > This patch decouples OpenRISC from asm-generic/atomic.h. Subsequent
> > patches will simplify the asm-generic implementation.
> 
> This is fine, but just a thought.  If OpenRISC is the only architecture to do
> this then after this patch could we remove the ifndefs from
> asm-generic/atomic.h as additional cleanup?

Yup! That's done in patch 8. :)

I'll expand the wording in this commit message to explicitly mention
that subsequent patches will remove the ifdeferry, rather than just
simplfying the asm-generic implementation.

[...]

> Acked-by: Stafford Horne <shorne@...il.com>

Thanks!

Mark.