linux-kernel - Re: [PATCH] x86/acpi: Switch to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YJ5O5gytKMDOCnFz@gmail.com>
Date:   Fri, 14 May 2021 12:20:22 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        the arch/x86 maintainers <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/acpi: Switch to pr_xxx log functions


* Rafael J. Wysocki <rafael@...nel.org> wrote:

> On Fri, May 14, 2021 at 9:07 AM Ingo Molnar <mingo@...nel.org> wrote:
> >
> >
> > * Heiner Kallweit <hkallweit1@...il.com> wrote:
> >
> > > Switching to pr_debug et al has two benefits:
> > > - We don't have to add PREFIX to each log statement
> > > - Debug output is suppressed except DEBUG is defined or dynamic
> > >   debugging is enabled for the respective code piece.
> > >
> > > In addition ensure that longer messages aren't split to multiple lines
> > > in source code, checkpatch complains otherwise.
> > >
> > > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> > > ---
> > >  arch/x86/kernel/acpi/boot.c | 118 ++++++++++++++----------------------
> > >  1 file changed, 47 insertions(+), 71 deletions(-)
> >
> > Reviewed-by: Ingo Molnar <mingo@...nel.org>
> 
> So I'm going to take this through the ACPI tree if that's OK.

Sure!

Thanks,

	Ingo