linux-kernel - Re: [PATCH] ACPI/IORT: Handle device properties with software node API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 May 2021 16:13:28 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     Hanjun Guo <guohanjun@...wei.com>,
        Sudeep Holla <sudeep.holla@....com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Jean-Philippe Brucker <jean-philippe@...aro.org>,
        Joerg Roedel <jroedel@...e.de>,
        Eric Auger <eric.auger@...hat.com>,
        Will Deacon <will@...nel.org>, linux-acpi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI/IORT: Handle device properties with software node
 API

On Fri, May 14, 2021 at 11:39:12AM +0100, Lorenzo Pieralisi wrote:
> On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote:
> > The older device property API is going to be removed.
> > Replacing the device_add_properties() call with software
> > node API equivalent device_create_managed_software_node().
> > 
> > Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
> 
> Is this really fixing anything ? I am not sure I understand what you
> would like to achieve with this tag.

Right now it's not possible to simply remove the old API because some
of the maintainers want to take care of the conversion themselves, but
at the same time I also do not want to see any new releases of the
kernel that introduce more users for it. That's why it's a fix.


> > Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > ---
> >  drivers/acpi/arm64/iort.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> With the above comment clarified:
> 
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> 
> > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> > index 3912a1f6058e5..e34937e11186a 100644
> > --- a/drivers/acpi/arm64/iort.c
> > +++ b/drivers/acpi/arm64/iort.c
> > @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
> >  				      FIELD_GET(ACPI_IORT_NC_PASID_BITS,
> >  						nc->node_flags));
> >  
> > -	if (device_add_properties(dev, props))
> > +	if (device_create_managed_software_node(dev, props, NULL))
> >  		dev_warn(dev, "Could not add device properties\n");
> >  }
> >  
> > -- 
> > 2.30.2
> > 

thanks,

-- 
heikki