linux-kernel - Re: [PATCH v1 1/2] power: supply: sbs-battery: Silence warning about unknown chemistry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76b598cc-570e-96ac-8456-0ce481aedaeb@gmail.com>
Date:   Fri, 14 May 2021 16:13:39 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Antoni Aloy Torrens <aaloytorrens@...il.com>,
        Nikola Milosavljević <mnidza@...look.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] power: supply: sbs-battery: Silence warning about
 unknown chemistry

13.05.2021 18:11, Sebastian Reichel пишет:
> Hi,
> 
> On Tue, May 11, 2021 at 01:08:26AM +0300, Dmitry Osipenko wrote:
>> Older variants of controller don't support reporting type of the battery.
>> Make warning message about unknown chemistry to be printed only once in
>> order to stop flooding kernel log with the message on each request of the
>> property. This patch fixes the noisy messages on Asus Transformer TF101.
>>
>> Tested-by: Antoni Aloy Torrens <aaloytorrens@...il.com> # TF101
>> Tested-by: Nikola Milosavljević <mnidza@...look.com> # TF101
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>> ---
> 
> I believe the problem should be fixed as side-effect of the
> following patch:
> 
> https://lore.kernel.org/linux-pm/20210513020308.4011440-1-ikjn@chromium.org/
> 
> With my suggested change the message is printed once for each
> battery plug, so probably only once per boot for most users.

Looks like that patch indeed should work too, thank you.