linux-kernel - Re: [PATCH] MIPS: ralink: of: fix build of rt2880

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b9afccc-31d0-92c4-d64a-03a3ce139337@phrozen.org>
Date:   Fri, 14 May 2021 20:31:55 +0200
From:   John Crispin <john@...ozen.org>
To:     Guenter Roeck <linux@...ck-us.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org
Cc:     Lee Jones <lee.jones@...aro.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module


On 14.05.21 15:48, Guenter Roeck wrote:
> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
>> When rt2880_wdt watchdog driver is built as a module, the
>> rt_sysc_membase needs to be exported (it is being used via inlined
>> rt_sysc_r32):
>>
>>    ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] 
>> undefined!
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>
> Acked-by: Guenter Roeck <linux@...ck-us.net>
>
> I don't see a recent change in the code. Has that problem been there
> all along ?
>
>
yes it has ...

Acked-by: John Crispin <john@...ozen.org>