linux-kernel - Re: [PATCH][V2][next] drm/vmwgfx: Fix memory allocation check and a leak of object fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <859a6800-5c5e-b6cc-50af-8bd4560cf35b@vmware.com>
Date:   Fri, 14 May 2021 14:32:21 -0400
From:   Zack Rusin <zackr@...are.com>
To:     Colin King <colin.king@...onical.com>,
        VMware Graphics <linux-graphics-maintainer@...are.com>,
        Roland Scheidegger <sroland@...are.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2][next] drm/vmwgfx: Fix memory allocation check and a
 leak of object fifo

On 5/14/21 10:49 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The allocation of fifo is lacking an allocation failure check, so
> fix this by adding one.
> 
> In the case where fifo->static_buffer fails to be allocated the
> error return path neglects to kfree the fifo object. Fix this by
> adding in the missing kfree.
> 
> Kudos to Dan Carpenter for spotting the missing kzalloc failure
> check.
> 
> Addresses-Coverity: ("Resource leak")
> Fixes: 2cd80dbd3551 ("drm/vmwgfx: Add basic support for SVGA3")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> 
> V2: Add missing allocation failure check
>      Update $SUBJECT to reflect this extra change

Looks good. Thanks. I'll push it through drm-misc-next.

z