linux-kernel - Re: [PATCH -next] drm/vmwgfx: Fix return value check in vmw_setup_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d8f8ef46-5a27-5011-3c93-198ad57dafb3@vmware.com>
Date:   Fri, 14 May 2021 14:33:31 -0400
From:   Zack Rusin <zackr@...are.com>
To:     Qiheng Lin <linqiheng@...wei.com>,
        VMware Graphics <linux-graphics-maintainer@...are.com>,
        Roland Scheidegger <sroland@...are.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] drm/vmwgfx: Fix return value check in
 vmw_setup_pci_resources()

On 5/14/21 4:28 AM, Qiheng Lin wrote:
> In case of error, the function devm_ioremap() returns NULL pointer not ERR_PTR().
> The IS_ERR() test in the return value check should be replaced with NULL test.
> After that, the error code -ENOMEM should be returned.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Qiheng Lin <linqiheng@...wei.com>

Looks good. Thank you. I'll push it with some other fixes via drm-misc-next.

z