linux-kernel - Re: [PATCH 26/94] Maple Tree: Add new data structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 May 2021 20:36:37 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Song Liu <songliubraving@...com>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Laurent Dufour <ldufour@...ux.ibm.com>,
        David Rientjes <rientjes@...gle.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Rik van Riel <riel@...riel.com>,
        Michel Lespinasse <walken.cr@...il.com>
Subject: Re: [PATCH 26/94] Maple Tree: Add new data structure


Hello Peter,

Thank you for looking at this patch set!

* Peter Zijlstra <peterz@...radead.org> [210514 06:41]:
> On Wed, Apr 28, 2021 at 03:36:02PM +0000, Liam Howlett wrote:
> 
> > +/* Flags:
> > + * MAPLE_ALLOC_RANGE	Use allocation ranges (tracks gaps) in this tree
> > + * MAPLE_USE_RCU	Operate in read/copy/update mode for multi-readers.
> > + * MAPLE_HEIGHT_OFFSET	The position of the tree height in the flags
> > + * MAPLE_HEIGHT_MASK	The mask for the maple tree height value.
> > + */
> 
> Regular comment style would be:
> 
> /*
>  * Flags:
>  ...
>  */

I will fix this.

> 
> > +#define MAPLE_ALLOC_RANGE	1	// Bit 0
> > +#define MAPLE_USE_RCU		2	// Bit 1
> > +#define	MAPLE_HEIGHT_OFFSET	2	// Bit 2
> > +#define	MAPLE_HEIGHT_MASK	60	// Bits 2-5
> 
> Can we pretty please keep masks in hex, like:
> 
> #define MAPLE_HEIGHT_MASK	0x3c
> 
> Because then it's instantly obvious is it bits 2-5.
> 

Sure, I will change them all to two digit hex so they align.  I should
probably check that whitespace too.