linux-kernel - Re: [PATCH v2] samples/kprobes: Fix typo in handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <BA687AE0-EB7F-4A27-9868-5CCD83FF1E76@koderer.com>
Date:   Fri, 14 May 2021 11:28:07 +0200
From:   "Koderer, Marc" <marc@...erer.com>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Jonathan Corbet <corbet@....net>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Jisheng Zhang <jszhang@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] samples/kprobes: Fix typo in handler_post()


> On 14. May 2021, at 10:10, Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
> 
> It should use post_handler instead of pre_handler in handler_post().
> 
> Fixes: e16c5dd5157e ("samples/kprobes: Add s390 case in kprobe example module")
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>


LGTM.
Acked-by: Marc Koderer <marc@...erer.com>

Thanks.

> ---
> 
> v2: rebase on the latest mainline kernel
> 
> samples/kprobes/kprobe_example.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index c495664..602db3f 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -89,7 +89,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
> 		p->symbol_name, p->addr, regs->status);
> #endif
> #ifdef CONFIG_S390
> -	pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
> +	pr_info("<%s> post_handler: p->addr, 0x%p, flags = 0x%lx\n",
> 		p->symbol_name, p->addr, regs->flags);
> #endif
> }
> -- 
> 2.1.0
>