linux-kernel - Re: [PATCH v2] samples/kprobes: Fix typo in handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 May 2021 09:29:51 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Joe Perches <joe@...ches.com>, Jonathan Corbet <corbet@....net>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Marc Koderer <marc@...erer.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Jisheng Zhang <jszhang@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] samples/kprobes: Fix typo in handler_post()

On 05/14/2021 11:26 PM, Joe Perches wrote:
> On Fri, 2021-05-14 at 16:10 +0800, Tiezhu Yang wrote:
>> It should use post_handler instead of pre_handler in handler_post().
>>
>> Fixes: e16c5dd5157e ("samples/kprobes: Add s390 case in kprobe example module")
>> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
>> ---
>>
>> v2: rebase on the latest mainline kernel
>>
>>   samples/kprobes/kprobe_example.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
>> index c495664..602db3f 100644
>> --- a/samples/kprobes/kprobe_example.c
>> +++ b/samples/kprobes/kprobe_example.c
>> @@ -89,7 +89,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
>>   		p->symbol_name, p->addr, regs->status);
>>   #endif
>>   #ifdef CONFIG_S390
>> -	pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
>> +	pr_info("<%s> post_handler: p->addr, 0x%p, flags = 0x%lx\n",
>>   		p->symbol_name, p->addr, regs->flags);
>>   #endif
>>   }
> Perhaps better would be to use pr_fmt and remove all the
> embedded pre/post strings.
>
> This would change the style of the output through.
>
> Also fix a defective format in handler_fault ending with
> an 'n' that should be '\n'

Thank you, it looks better, let me send v3 as you suggested.

[...]