linux-kernel - Re: hwmon: (pcf8591) Unused attribute group pcf8591_attr_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2d6122d1-e9fa-1e23-1e81-50c6ade08d2f@roeck-us.net>
Date:   Sat, 15 May 2021 06:44:42 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Evgeny Novikov <novikov@...ras.ru>,
        Jean Delvare <jdelvare@...e.com>
Cc:     "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ldv-project@...uxtesting.org" <ldv-project@...uxtesting.org>
Subject: Re: hwmon: (pcf8591) Unused attribute group pcf8591_attr_group_opt

On 5/15/21 6:20 AM, Evgeny Novikov wrote:
> Driver drivers/hwmon/pcf8591.ko declares and removes attribute group
> pcf8591_attr_group_opt, but it does not create it ever. Is it better to remove
> it completely or to do something else?

Do nothing. Look closely at the file instead to see how the attributes
are created, and realize that the group is only used to simplify
attribute removal.

Yes, the code is a bit odd and unusual, but it is WAI.

Guenter