linux-kernel - Re: hwmon: (w83781d) Unused attribute group w83781d_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ed3df026-3d47-45bf-dd1b-c0f2dc5cd02a@roeck-us.net>
Date:   Sat, 15 May 2021 06:48:12 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Evgeny Novikov <novikov@...ras.ru>,
        Jean Delvare <jdelvare@...e.com>
Cc:     "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        ldv-project-org <ldv-project@...uxtesting.org>
Subject: Re: hwmon: (w83781d) Unused attribute group w83781d_group_other

On 5/15/21 6:29 AM, Evgeny Novikov wrote:
> Driver drivers/hwmon/w83781d.ko declares and removes attribute group
> w83781d_group_other, but it does not create it ever. Is it better to remove
> it completely or to do something else?

Do nothing. The group is only used to remove the attributes.
The attributes are created one by one, not using the group.
This is WAI.

Oh, there _is_ something you can do: Fix the Linux Driver Verification
project scripts to no longer result in those false positives.

Guenter