linux-kernel - Re: [PATCH] nvmet: fix memory leak on nvmet_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB4965E8D55C4349EC01EF61FB862C9@BYAPR04MB4965.namprd04.prod.outlook.com>
Date:   Tue, 18 May 2021 20:27:43 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Wu Bo <wubo40@...wei.com>, "kbusch@...nel.org" <kbusch@...nel.org>
CC:     "hch@....de" <hch@....de>, "sagi@...mberg.me" <sagi@...mberg.me>,
        "amit.engel@...l.com" <amit.engel@...l.com>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linfeilong@...wei.com" <linfeilong@...wei.com>
Subject: Re: [PATCH] nvmet: fix memory leak on nvmet_alloc_ctrl()

On 5/18/21 01:21, Wu Bo wrote:
> From: Wu Bo <wubo40@...wei.com>
>
> When cntlid_min is greater than cntlid_max,
> goto wrong label, should be goto out_free_sqs
> label. Otherwise there is a memory leak problem
> on the nvmet_alloc_ctrl function().
>
> Fixes: 94a39d61f80f ("nvmet: make ctrl-id configurable")
> Fixes: 6d65aeab7bf6e ("nvmet: remove unused ctrl->cqs")
> Signed-off-by: Wu Bo <wubo40@...wei.com>
> ---

Looks good, except commit message could be better :-

When cntlid_min is greater than cntlid_max, goto wrong label, should be
goto out_free_sqs label. Otherwise there is a memory leak problem on the
nvmet_alloc_ctrl function(). 

Fixes: 94a39d61f80f ("nvmet: make ctrl-id configurable")
Fixes: 6d65aeab7bf6 ("nvmet: remove unused ctrl->cqs")
Signed-off-by: Wu Bo <wubo40@...wei.com>


with above :-

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>