[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ead259ae-2955-1fda-7deb-6262fdc21ecf@huawei.com>
Date: Wed, 19 May 2021 12:32:17 +0800
From: Wu Bo <wubo40@...wei.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>,
"kbusch@...nel.org" <kbusch@...nel.org>
CC: "hch@....de" <hch@....de>, "sagi@...mberg.me" <sagi@...mberg.me>,
"amit.engel@...l.com" <amit.engel@...l.com>,
"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linfeilong@...wei.com" <linfeilong@...wei.com>
Subject: Re: [PATCH] nvmet: fix memory leak on nvmet_alloc_ctrl()
On 2021/5/19 4:27, Chaitanya Kulkarni wrote:
> On 5/18/21 01:21, Wu Bo wrote:
>> From: Wu Bo <wubo40@...wei.com>
>>
>> When cntlid_min is greater than cntlid_max,
>> goto wrong label, should be goto out_free_sqs
>> label. Otherwise there is a memory leak problem
>> on the nvmet_alloc_ctrl function().
>>
>> Fixes: 94a39d61f80f ("nvmet: make ctrl-id configurable")
>> Fixes: 6d65aeab7bf6e ("nvmet: remove unused ctrl->cqs")
>> Signed-off-by: Wu Bo <wubo40@...wei.com>
>> ---
>
> Looks good, except commit message could be better :-
>
> When cntlid_min is greater than cntlid_max, goto wrong label, should be
> goto out_free_sqs label. Otherwise there is a memory leak problem on the
> nvmet_alloc_ctrl function().
>
> Fixes: 94a39d61f80f ("nvmet: make ctrl-id configurable")
> Fixes: 6d65aeab7bf6 ("nvmet: remove unused ctrl->cqs")
> Signed-off-by: Wu Bo <wubo40@...wei.com>
>
>
> with above :-
Thanks for your review. I will make the commit message better.
and I found the nvmet-loop has a similar issue,
will send patch series soon.
Thanks,
Wu Bo
>
> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>
>
>
> .
>
Powered by blists - more mailing lists