linux-kernel - Re: [PATCH v2 1/6] staging: rtl8188eu: use safe iterator in rtw_free_network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210518074453.GM1955@kadam>
Date:   Tue, 18 May 2021 10:44:53 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-staging@...ts.linux.dev, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/6] staging: rtl8188eu: use safe iterator in
 rtw_free_network_queue

On Mon, May 17, 2021 at 10:18:21PM +0200, Martin Kaiser wrote:
> rtw_free_network_queue iterates over the scanned wireless networks and
> calls _rtw_free_network for each of them. In some cases,
> _rtw_free_network removes a network from the list.
> 
> We have to use list_for_each_entry_safe if we remove list entries while
> we iterate over a list.
> 
> Fixes: 23017c8842d2 ("staging: rtl8188eu: Use list iterators and helpers")
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
> v2:
>  - use list_for_each_entry_safe
> 

I hadn't intended for you to redo the patch otherwise I would have
asked you to include endless loop script in all the commit messages
and rename "temp" (temperatures) to "tmp" (temporary).

You have to learn to let go, patches are never perfect.  But let's say
that these v2 patch are perfect and add a:

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

Don't resend!  :)

regards,
dan carpenter