linux-kernel - Re: [PATCH 1/6] staging: rtl8188eu: use safe iterator in rtw_free_network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210518082855.GB32682@kadam>
Date:   Tue, 18 May 2021 11:28:55 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-staging@...ts.linux.dev, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging: rtl8188eu: use safe iterator in
 rtw_free_network_queue

On Mon, May 17, 2021 at 06:57:33PM +0300, Dan Carpenter wrote:
> Thanks for catching these...  I've created a new Smatch static checker
> warning for this but it only works for list_for_each_entry().
> Eventually someone would have run the coccinelle script to convert these
> list_for_each loops into list_for_each_entry().  Otherwise you have to
> parse container_of() and I've been meaning to do that for a while but I
> haven't yet.
> 
> Anyway, I'm going to test it out overnight and see what it finds.  It's
> sort a new use for the modification_hook(), before I had only ever used
> it to silence warnings but this check uses it to trigger warnings.  So
> perhaps it will generate a lot of false positives.  We'll see.
> 
> It sets the state of the iterator to &start at the start of the loop
> and if it's not &start state at the end then it prints a warning.
> 
> regards,
> dan carpenter
> 

That Smatch check didn't work at all.  :P  Back to the drawing board.

regards,
dan carpenter