linux-kernel - Re: [PATCH 2/5] mm/swap: remove unused local variable nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b7bd04e-4995-1bfb-0c42-81bad94fd4a4@huawei.com>
Date:   Wed, 19 May 2021 09:37:33 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
        <linux-mm@...ck.org>
Subject: Re: [PATCH 2/5] mm/swap: remove unused local variable nr_shadows

On 2021/5/18 22:37, Matthew Wilcox wrote:
> On Tue, May 18, 2021 at 09:53:49PM +0800, Miaohe Lin wrote:
>> Since commit 55c653b71e8c ("mm: stop accounting shadow entries"),
>> nr_shadows is not used anymore.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> 
> Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> 
>> +++ b/mm/swap_state.c
>> @@ -114,7 +114,6 @@ int add_to_swap_cache(struct page *page, swp_entry_t entry,
>>  	SetPageSwapCache(page);
>>  
>>  	do {
>> -		unsigned long nr_shadows = 0;
>>  
> 
> Perhaps delete the blank line as well?

Will do. Many thanks for the review.

> 
> .
>