linux-kernel - Re: [PATCH 5/5] mm/swap: simplify the code of find_get_incore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b74ae719-41a4-80d2-95ae-ce0122d21338@huawei.com>
Date:   Wed, 19 May 2021 09:39:52 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>
Subject: Re: [PATCH 5/5] mm/swap: simplify the code of find_get_incore_page()

On 2021/5/19 5:34, Matthew Wilcox wrote:
> On Tue, May 18, 2021 at 02:13:04PM -0700, Andrew Morton wrote:
>> On Tue, 18 May 2021 15:33:54 +0100 Matthew Wilcox <willy@...radead.org> wrote:
>>
>>> On Tue, May 18, 2021 at 09:53:52PM +0800, Miaohe Lin wrote:
>>>> pagecache_get_page() can do find_subpage() for us if we do not specify
>>>> FGP_HEAD. No functional change intended.
>>>
>>> Please, no.  This interferes with the folio work.
>>
>> In what way?  Can't the folio patches simply revert this or suitably
>> alter it?
> 
> Of course, it's just software.  Anything can just be modified.  I don't
> see the point of putting in a cleanup patch that creates a conflict with
> important work.

I could hold this patch out until folio work is done if you ask for it.
Thanks.

> .
>