linux-kernel - Re: [PATCH] arch/mips/boot/compressed/string.c: Fix build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <N8YCTQ.J6CD851ZEGJ73@crapouillou.net>
Date:   Wed, 19 May 2021 15:14:47 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     zhaoxiao <zhaoxiao@...ontech.com>, tsbogend@...ha.franken.de,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch/mips/boot/compressed/string.c: Fix build warnings

Hi,

Le mer., mai 19 2021 at 22:00:07 +0800, Jiaxun Yang 
<jiaxun.yang@...goat.com> a écrit :
> 
> 
> 在 2021/5/19 16:44, zhaoxiao 写道:
>> Fixes the following W=1 kernel build warning(s):
>> arch/mips/boot/compressed/string.c:11:7: warning: no previous 
>> prototype for 'memcpy' [-Wmissing-prototypes]
>>   void *memcpy(void *dest, const void *src, size_t n)
>>         ^~~~~~
>> arch/mips/boot/compressed/string.c:22:7: warning: no previous 
>> prototype for 'memset' [-Wmissing-prototypes]
>>   void *memset(void *s, int c, size_t n)
>>         ^~~~~~
>> arch/mips/boot/compressed/string.c:32:15: warning: no previous 
>> prototype for 'memmove' [-Wmissing-prototypes]
>>   void * __weak memmove(void *dest, const void *src, size_t n)
> Hi Xiao,
> 
> Are you sure you know what you're doing?
> 
> They're supposed to be called by external reference in vmlinuz.
> Marking them static makes no sense.

I was wondering that too.

I suppose including <asm/string.h> should be enough to fix the warnings.

Cheers,
-Paul

>>                 ^~~~~~~
>> 
>> Signed-off-by: zhaoxiao <zhaoxiao@...ontech.com>
>> ---
>>   arch/mips/boot/compressed/string.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/arch/mips/boot/compressed/string.c 
>> b/arch/mips/boot/compressed/string.c
>> index 0b593b709228..d28996509f91 100644
>> --- a/arch/mips/boot/compressed/string.c
>> +++ b/arch/mips/boot/compressed/string.c
>> @@ -8,7 +8,7 @@
>>   #include <linux/compiler_attributes.h>
>>   #include <linux/types.h>
>>   -void *memcpy(void *dest, const void *src, size_t n)
>> +static void *memcpy(void *dest, const void *src, size_t n)
>>   {
>>   	int i;
>>   	const char *s = src;
>> @@ -19,7 +19,7 @@ void *memcpy(void *dest, const void *src, size_t n)
>>   	return dest;
>>   }
>>   -void *memset(void *s, int c, size_t n)
>> +static void *memset(void *s, int c, size_t n)
>>   {
>>   	int i;
>>   	char *ss = s;
>> @@ -29,7 +29,7 @@ void *memset(void *s, int c, size_t n)
>>   	return s;
>>   }
>>   -void * __weak memmove(void *dest, const void *src, size_t n)
>> +static void * __weak memmove(void *dest, const void *src, size_t n)
>>   {
>>   	unsigned int i;
>>   	const char *s = src;
>