linux-kernel - Re: [PATCH] scsi: libsas: use _safe() loop in sas_resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53700bc0-b2a0-3d65-5471-ff20f3127790@huawei.com>
Date:   Wed, 19 May 2021 15:48:26 +0100
From:   John Garry <john.garry@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Dan Williams <dan.j.williams@...el.com>
CC:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Jacek Danecki <jacek.danecki@...el.com>,
        "James Bottomley" <JBottomley@...allels.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] scsi: libsas: use _safe() loop in sas_resume_port()

On 19/05/2021 15:20, Dan Carpenter wrote:
> If sas_notify_lldd_dev_found() fails then this code calls:
> 
> 	sas_unregister_dev(port, dev);
> 
> which removes "dev", our list iterator, from the list.  This could
> lead to an endless loop.  We need to use list_for_each_entry_safe().
> 
> Fixes: 303694eeee5e ("[SCSI] libsas: suspend / resume support")
> Signed-off-by: Dan Carpenter<dan.carpenter@...cle.com>

Reviewed-by: John Garry <john.garry@...wei.com>