linux-kernel - Re: [PATCH] scsi: libsas: use _safe() loop in sas_resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <162165838886.5676.17251463121034866403.b4-ty@oracle.com>
Date:   Sat, 22 May 2021 00:40:31 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Dan Williams <dan.j.williams@...el.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Alan Stern <stern@...land.harvard.edu>,
        linux-scsi@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        James Bottomley <JBottomley@...allels.com>,
        Jacek Danecki <jacek.danecki@...el.com>
Subject: Re: [PATCH] scsi: libsas: use _safe() loop in sas_resume_port()

On Wed, 19 May 2021 17:20:27 +0300, Dan Carpenter wrote:

> If sas_notify_lldd_dev_found() fails then this code calls:
> 
> 	sas_unregister_dev(port, dev);
> 
> which removes "dev", our list iterator, from the list.  This could
> lead to an endless loop.  We need to use list_for_each_entry_safe().

Applied to 5.13/scsi-fixes, thanks!

[1/1] scsi: libsas: use _safe() loop in sas_resume_port()
      https://git.kernel.org/mkp/scsi/c/8c7e7b8486cd

-- 
Martin K. Petersen	Oracle Linux Engineering