linux-kernel - Re: [PATCH 2/2] staging: rtl8723bs: hal: rtl8723b_hal_init: Remove unused variable and dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210520123647.GG1955@kadam>
Date:   Thu, 20 May 2021 15:36:47 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marco Cesati <marcocesati@...il.com>,
        Fabio Aiuto <fabioaiuto83@...il.com>, Stanley@...SD3,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH 2/2] staging: rtl8723bs: hal: rtl8723b_hal_init: Remove
 unused variable and dead code

On Thu, May 20, 2021 at 01:26:20PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c: In function ‘CCX_FwC2HTxRpt_8723b’:
>  drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:3355:5: warning: variable ‘seq_no’ set but not used [-Wunused-but-set-variable]
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Marco Cesati <marcocesati@...il.com>
> Cc: Fabio Aiuto <fabioaiuto83@...il.com>
> Cc: Stanley@...SD3
> Cc: linux-staging@...ts.linux.dev
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index 33942ab587720..0270724ccef03 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -3204,14 +3204,9 @@ void CCX_FwC2HTxRpt_8723b(struct adapter *padapter, u8 *pdata, u8 len)
>  
>  	if (GET_8723B_C2H_TX_RPT_RETRY_OVER(pdata) | GET_8723B_C2H_TX_RPT_LIFE_TIME_OVER(pdata)) {
>  		rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_CCX_PKT_FAIL);
> -	}
> -/*
> -	else if (seq_no != padapter->xmitpriv.seq_no) {
> -		rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_CCX_PKT_FAIL);
> -	}
> -*/
> -	else
> +	} else {
>  		rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_SUCCESS);
> +	}

The commit message was quite puzzling because "seq_no" doesn't exist.
Could you resend with a fixed commit message that says "Delete commented
out code" or whatever?

regards,
dan carpenter