linux-kernel - Re: [PATCH v3 1/8] x86/traps: add X86_NR_HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 May 2021 09:10:41 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...en8.de>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/8] x86/traps: add X86_NR_HW_TRAPS to <asm/trapnr.h>

On Wed, May 19 2021 at 15:24, H. Peter Anvin wrote:

  A: Because it messes up the order in which people normally read text.
  Q: Why is top-posting such a bad thing?

  A: Top-posting.
  Q: What is the most annoying thing in e-mail?

  A: No.
  Q: Should I include quotations after my reply?

> On May 19, 2021 3:17:57 PM PDT, Thomas Gleixner <tglx@...utronix.de> wrote:
>> On Wed, May 19 2021 at 14:21, H. Peter Anvin wrote:
>>> The x86 architecture supports up to 32 trap vectors. Add that
>>> constant to <asm/trapnr.h>.
>>
>> Where is that actually used?
>
> It is not right now, but it will be used in the FRED enabling patchset
> at the very least (since the number of exception vectors and
> FIRST_EXTERNAL_VECTOR are not necessarily the same anymore.)

Then add it with FRED. Defining unused stuff will just result in cleanup
patches which removed unused defines...

Thanks,

        tglx