linux-kernel - Re: [PATCH v3] ACPI: EC: Make more Asus laptops use ECDT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h3j+t3URKdM=WidytiAWx0N8jL6JnED11r4BCH5vDOHw@mail.gmail.com>
Date:   Fri, 21 May 2021 19:18:34 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Jian-Hong Pan <jhp@...lessos.org>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux@...lessos.org, Chris Chiu <chris.chiu@...onical.com>
Subject: Re: [PATCH v3] ACPI: EC: Make more Asus laptops use ECDT _GPE

On Thu, May 20, 2021 at 5:13 AM Jian-Hong Pan <jhp@...lessos.org> wrote:
>
> From: Chris Chiu <chris.chiu@...onical.com>
>
> More ASUS laptops have the _GPE define in the DSDT table with a
> different value than the _GPE number in the ECDT.
>
> This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
>
> Add model info to the quirks list.
>
> Signed-off-by: Chris Chiu <chris.chiu@...onical.com>
> Signed-off-by: Jian-Hong Pan <jhp@...lessos.org>
> ---
> v2: Edit the author information with valid email address
>
> v3: Edit Chris' S-o-b with current valid email address
>
>  drivers/acpi/ec.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 13565629ce0a..e8c5da2b964a 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
>         DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>         DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
>         {
> +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +       DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> +       {
> +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +       DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> +       {
> +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +       DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> +       {
> +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +       DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> +       {
>         ec_honor_ecdt_gpe, "ASUS X550VXK", {
>         DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>         DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> --

Applied as 5.14 material, thanks!