linux-kernel - Re: [PATCH 1/4] DMA: ALTERA_MSGDMA depends on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4fde705b-6d57-ba73-e7d6-63beb690117e@denx.de>
Date:   Sat, 22 May 2021 09:21:24 +0200
From:   Stefan Roese <sr@...x.de>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Vinod Koul <vkoul@...nel.org>, dmaengine@...r.kernel.org,
        Sinan Kaya <okaya@...eaurora.org>,
        Green Wan <green.wan@...ive.com>,
        Hyun Kwon <hyun.kwon@...inx.com>,
        Tejas Upadhyay <tejasu@...inx.com>,
        Michal Simek <michal.simek@...inx.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/4] DMA: ALTERA_MSGDMA depends on HAS_IOMEM

On 22.05.21 04:13, Randy Dunlap wrote:
> When CONFIG_HAS_IOMEM is not set/enabled, certain iomap() family
> functions [including ioremap(), devm_ioremap(), etc.] are not
> available.
> Drivers that use these functions should depend on HAS_IOMEM so that
> they do not cause build errors.
> 
> Repairs this build error:
> s390-linux-ld: drivers/dma/altera-msgdma.o: in function `request_and_map':
> altera-msgdma.c:(.text+0x14b0): undefined reference to `devm_ioremap'
> 
> Fixes: a85c6f1b2921 ("dmaengine: Add driver for Altera / Intel mSGDMA IP core")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Stefan Roese <sr@...x.de>
> Cc: Vinod Koul <vkoul@...nel.org>
> Cc: dmaengine@...r.kernel.org

Reviewed-by: Stefan Roese <sr@...x.de>

Thanks,
Stefan

> ---
>   drivers/dma/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- linux-next-20210521.orig/drivers/dma/Kconfig
> +++ linux-next-20210521/drivers/dma/Kconfig
> @@ -59,6 +59,7 @@ config DMA_OF
>   #devices
>   config ALTERA_MSGDMA
>   	tristate "Altera / Intel mSGDMA Engine"
> +	depends on HAS_IOMEM
>   	select DMA_ENGINE
>   	help
>   	  Enable support for Altera / Intel mSGDMA controller.
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@...x.de