linux-kernel - Re: [PATCH 4/4] DMA: XILINX_ZYNQMP_DPDMA depends on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKmfs68Cq4osBaQ0@pendragon.ideasonboard.com>
Date:   Sun, 23 May 2021 03:20:03 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Stefan Roese <sr@...x.de>,
        Vinod Koul <vkoul@...nel.org>, dmaengine@...r.kernel.org,
        Sinan Kaya <okaya@...eaurora.org>,
        Green Wan <green.wan@...ive.com>,
        Hyun Kwon <hyun.kwon@...inx.com>,
        Tejas Upadhyay <tejasu@...inx.com>,
        Michal Simek <michal.simek@...inx.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 4/4] DMA: XILINX_ZYNQMP_DPDMA depends on HAS_IOMEM

Hi Randy,

Thank you for the patch.

On Fri, May 21, 2021 at 07:13:13PM -0700, Randy Dunlap wrote:
> When CONFIG_HAS_IOMEM is not set/enabled, most iomap() family
> functions [including ioremap(), devm_ioremap(), etc.] are not
> available.
> Drivers that use these functions should depend on HAS_IOMEM so that
> they do not cause build errors.
> 
> Cures this build error:
> s390-linux-ld: drivers/dma/xilinx/xilinx_dpdma.o: in function `xilinx_dpdma_probe':
> xilinx_dpdma.c:(.text+0x336a): undefined reference to `devm_platform_ioremap_resource'

I've previously posted
https://lore.kernel.org/dmaengine/20210520152420.23986-2-laurent.pinchart@ideasonboard.com/T/#u
which fixes the same issue (plus an additional one).

> Fixes: 7cbb0c63de3fc ("dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Vinod Koul <vkoul@...nel.org>
> CC: dmaengine@...r.kernel.org
> Cc: Hyun Kwon <hyun.kwon@...inx.com>
> Cc: Tejas Upadhyay <tejasu@...inx.com>
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
>  drivers/dma/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20210521.orig/drivers/dma/Kconfig
> +++ linux-next-20210521/drivers/dma/Kconfig
> @@ -702,6 +702,7 @@ config XILINX_ZYNQMP_DMA
>  
>  config XILINX_ZYNQMP_DPDMA
>  	tristate "Xilinx DPDMA Engine"
> +	depends on HAS_IOMEM
>  	select DMA_ENGINE
>  	select DMA_VIRTUAL_CHANNELS
>  	help

-- 
Regards,

Laurent Pinchart