linux-kernel - Re: [PATCH v5 28/28] x86/fpu/amx: Clear the AMX state when appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJvTdKk-53JzUzgGbgWSsfMcGPjQ0Wvrb-AqYOhX3JArVsB=Qg@mail.gmail.com>
Date:   Mon, 24 May 2021 13:34:28 -0400
From:   Len Brown <lenb@...nel.org>
To:     Dave Hansen <dave.hansen@...el.com>
Cc:     "Chang S. Bae" <chang.seok.bae@...el.com>,
        Borislav Petkov <bp@...e.de>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, X86 ML <x86@...nel.org>,
        "Brown, Len" <len.brown@...el.com>,
        "Liu, Jing2" <jing2.liu@...el.com>,
        "Ravi V. Shankar" <ravi.v.shankar@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 28/28] x86/fpu/amx: Clear the AMX state when appropriate

On Mon, May 24, 2021 at 10:07 AM Dave Hansen <dave.hansen@...el.com> wrote:

> Could we maybe say:
>
>                 /*
>                  * Leaving state in the TILE registers may prevent the
>                  * processor from entering low-power idle states.  Use
>                  * TILERELEASE to initialize the state.  Destroying
>                  * fpregs state is safe after the fpstate update.
>                  */

Ack

> Also, referencing fpregs/fpstate is really nice because the codes
> doesn't actually say "XSAVE" anywhere.
>
> > +             if (fpu->state_mask & XFEATURE_MASK_XTILE_DATA)
> > +                     tile_release();
>
> Doesn't this tile_release() need a fpregs_deactivate()?  Otherwise, the
> next XRSTOR might get optimized away because it thinks there's still
> good data in the fpregs.
>
> Will this unnecessarily thwart the modified optimization in cases where
> we go and run this task again without ever going out to userspace?  Will
> this impact context-switch latency for *EVERY* context switch in order
> to go to a lower idle state in a few minutes, hours, or never?

yeah, seems we missed that.


thanks!
Len Brown, Intel Open Source Technology Center