linux-kernel - Re: [PATCH 2/2] char: pcmcia: scr24x_cs: Fix redundant fops Removed redundant fops assignment, which was already done in cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKtRSiVK1QEJasP+@demiurge.local>
Date:   Mon, 24 May 2021 09:10:02 +0200
From:   Lubomir Rintel <lkundrak@...sk>
To:     nizamhaider786@...il.com
Cc:     arnd@...db.de, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] char: pcmcia: scr24x_cs: Fix redundant fops Removed
 redundant fops assignment, which was already done in cdev_init()

On Sun, May 23, 2021 at 08:41:11PM +0530, nizamhaider786@...il.com wrote:
> From: Nijam Haider <nizamhaider786@...il.com>
> 

Thank you for this. Needs another spin though:

> Subject: [PATCH 2/2] char: pcmcia: scr24x_cs: Fix redundant fops Removed
                                                                  ^
It seems like you accidentally removed a line break here ---------|,
squishing the subject and patch description together.

>  redundant fops assignment, which was already done in cdev_init()

Regards,
Lubo

> Signed-off-by: Nijam Haider <nizamhaider786@...il.com>
> ---
>  drivers/char/pcmcia/scr24x_cs.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/pcmcia/scr24x_cs.c b/drivers/char/pcmcia/scr24x_cs.c
> index cad1990..0265d72 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -266,7 +266,6 @@ static int scr24x_probe(struct pcmcia_device *link)
>  
>  	cdev_init(&dev->c_dev, &scr24x_fops);
>  	dev->c_dev.owner = THIS_MODULE;
> -	dev->c_dev.ops = &scr24x_fops;
>  	ret = cdev_add(&dev->c_dev, MKDEV(MAJOR(scr24x_devt), dev->devno), 1);
>  	if (ret < 0)
>  		goto err;
> -- 
> 2.7.4
>