linux-kernel - Re: [PATCH] gpio: gpio-xgene: simplify probe, return devm_gpiochip_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAASAkoZWeQ3xSB3P-fLrym+_0b23HRuvaw3LW2Zgy9CVKr3AWQ@mail.gmail.com>
Date:   Mon, 24 May 2021 10:21:20 +0300
From:   Alexandru Ardelean <aardelean@...iqon.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] gpio: gpio-xgene: simplify probe, return
 devm_gpiochip_add_data() directly

On Sun, 23 May 2021 at 21:31, Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:
>
> On Fri, May 21, 2021 at 8:10 PM Alexandru Ardelean
> <aardelean@...iqon.com> wrote:
> >
> > The handling of the return value from devm_gpiochip_add_data() is a bit
> > redundant. It prints messages on error and success cases.
> > While the success message may be useful, it is more in the area of log
> > spam, and these can be printed with other forms of kernel logging.
> >
> > This change does a direct return with devm_gpiochip_add_data() in the probe
> > function.
> >
> > The platform_set_drvdata() is needed, as this driver uses the stored
> > private date in the PM suspend/resume routines.
> >
> > Signed-off-by: Alexandru Ardelean <aardelean@...iqon.com>
> > ---
> >  drivers/gpio/gpio-xgene.c | 11 +----------
> >  1 file changed, 1 insertion(+), 10 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
> > index 532b0df8a1f2..fb4b0c67aeef 100644
> > --- a/drivers/gpio/gpio-xgene.c
> > +++ b/drivers/gpio/gpio-xgene.c
> > @@ -159,7 +159,6 @@ static SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume);
> >  static int xgene_gpio_probe(struct platform_device *pdev)
> >  {
> >         struct xgene_gpio *gpio;
> > -       int err = 0;
> >
> >         gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
> >         if (!gpio)
> > @@ -183,15 +182,7 @@ static int xgene_gpio_probe(struct platform_device *pdev)
> >
> >         platform_set_drvdata(pdev, gpio);
> >
> > -       err = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
> > -       if (err) {
> > -               dev_err(&pdev->dev,
> > -                       "failed to register gpiochip.\n");
> > -               return err;
> > -       }
> > -
> > -       dev_info(&pdev->dev, "X-Gene GPIO driver registered.\n");
> > -       return 0;
> > +       return devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
> >  }
> >
> >  static const struct of_device_id xgene_gpio_of_match[] = {
> > --
> > 2.31.1
> >
>
> Applied, thanks.
>
> For the future: the subject should be: "gpio: xgene: ..." here and
> everywhere else.

ack
will keep that in mind

thanks :)
Alex

>
> Bart