linux-kernel - Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 May 2021 10:54:57 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Arnd Bergmann <arnd@...db.de>,
        Paul Burton <paul.burton@...s.com>,
        John Crispin <john@...ozen.org>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        "open list:TI ETHERNET SWITCH DRIVER (CPSW)" 
        <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled

Hi Dmitry,

On Mon, May 24, 2021 at 1:26 AM Dmitry Osipenko <digetx@...il.com> wrote:
> There are couple older platforms that can't be compile-tested because they
> partially implement CLK API. It causes build failure of kernel drivers due
> to the missing symbols of the unimplemented part of CLK API.
>
> These platforms are: ARM EP93XX, ARM OMAP1, m68k ColdFire, MIPS AR7,
>                      MIPS Ralink.
>
> Disable compile-testing for HAVE_LEGACY_CLK=y.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>

Thanks for your patch!

> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -131,7 +131,7 @@ config INIT_ENV_ARG_LIMIT
>
>  config COMPILE_TEST
>         bool "Compile also drivers which will not load"
> -       depends on HAS_IOMEM
> +       depends on HAS_IOMEM && !HAVE_LEGACY_CLK

That sounds a bit drastic to me.  Usually we just try to implement the
missing functionality, or provide stubs.
Which functions are missing?

>         help
>           Some drivers can be compiled on a different platform than they are
>           intended to be run on. Despite they cannot be loaded there (or even

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds