linux-kernel - RE: [PATCH v13 1/2] media: dt-bindings: imx-jpeg: Add compatible for i.MX8QM JPEG codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR04MB8477A2CA9717526D12C1465B80269@DB9PR04MB8477.eurprd04.prod.outlook.com>
Date:   Mon, 24 May 2021 03:19:21 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     "Mirela Rabulea (OSS)" <mirela.rabulea@....nxp.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "G.n. Zhou" <guoniu.zhou@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>
CC:     Peng Fan <peng.fan@....com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "paul.kocialkowski@...tlin.com" <paul.kocialkowski@...tlin.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Robert Chiras <robert.chiras@....com>,
        Laurentiu Palcu <laurentiu.palcu@....com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "ezequiel@...labora.com" <ezequiel@...labora.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Mirela Rabulea <mirela.rabulea@....com>
Subject: RE: [PATCH v13 1/2] media: dt-bindings: imx-jpeg: Add compatible for
 i.MX8QM JPEG codec

> From: Mirela Rabulea (OSS) <mirela.rabulea@....nxp.com>
> Sent: Sunday, May 23, 2021 5:11 AM
> 
> Add two more compatibles: "nxp,imx8qm-jpgdec" and " nxp,imx8qm-jpgenc".
> Also update the compatible property to ensure mutually exclusive usage of
> encoder and decoder compatibles.
> Update examples.
> 
> Signed-off-by: Mirela Rabulea <mirela.rabulea@....com>
> ---
>  .../bindings/media/nxp,imx8-jpeg.yaml           | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 5d13cbb5251b..5cc7b6a94c44 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -16,12 +16,15 @@ description: |-
> 
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -            # JPEG decoder
> -          - nxp,imx8qxp-jpgdec
> -            # JPEG encoder
> -          - nxp,imx8qxp-jpgenc
> +    oneOf:
> +      - items:
> +          anyOf:
> +            - const: nxp,imx8qxp-jpgdec
> +            - const: nxp,imx8qm-jpgdec
> +      - items:
> +          anyOf:

I might wish to avoid using anyOF for jpeg cases and defined in a more
Straightforward way.

e.g.
properties:
  compatible:
    oneOf:
      - items:
        - enum:
              # JPEG decoder
          - nxp,imx8qxp-jpgdec
            # JPEG encoder
          - nxp,imx8qxp-jpgenc
      - items:
          - enum:
              - nxp,imx8qm-jpgdec
          - const: nxp,imx8qxp-jpgdec
      - items:
          - enum:
              - nxp,imx8qm-jpgenc
          - const: nxp,imx8qxp-jpgenc
Could you check if it works?

Regards
Aisheng

> +            - const: nxp,imx8qxp-jpgenc
> +            - const: nxp,imx8qm-jpgenc
> 
>    reg:
>      maxItems: 1
> @@ -69,7 +72,7 @@ examples:
>      };
> 
>      jpegenc: jpegenc@...50000 {
> -        compatible = "nxp,imx8qxp-jpgenc";
> +        compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc";
>          reg = <0x58450000 0x00050000 >;
>          interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
>                       <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1