linux-kernel - Re: [PATCH RESEND 1/2] USB: serial: omninet: Adding Zyxel Omni 56K Plus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKyg2EYDn2BEnvYU@hovoldconsulting.com>
Date:   Tue, 25 May 2021 09:01:44 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Alexandre GRIVEAUX <agriveaux@...tnet.info>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 1/2] USB: serial: omninet: Adding Zyxel Omni 56K
 Plus

On Sun, May 23, 2021 at 06:35:21PM +0200, Alexandre GRIVEAUX wrote:
> Adding Zyxel Omni 56K Plus modem, this modem include:

Nit: In the future, try to use imperative mood in your commit messages
(i.e. use "add" rather than "adding").

Also, why is there a RESEND prefix in the subject? This is the first
time I see this patch.

> USB chip:
> NetChip
> NET2888
> 
> Main chip:
> 901041A
> F721501APGF
> 
> Another modem using the same chips is the Zyxel Omni 56K DUO/NEO,
> could be added with the right USB ID.
> 
> Signed-off-by: Alexandre GRIVEAUX <agriveaux@...tnet.info>
> ---
>  drivers/usb/serial/omninet.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
> index 83c62f920c50..8be91f5a4dd7 100644
> --- a/drivers/usb/serial/omninet.c
> +++ b/drivers/usb/serial/omninet.c
> @@ -26,6 +26,7 @@
>  
>  #define ZYXEL_VENDOR_ID		0x0586
>  #define ZYXEL_OMNINET_ID	0x1000
> +#define ZYXEL_OMNI_56K_PLUS_ID	0x1500
>  /* This one seems to be a re-branded ZyXEL device */
>  #define BT_IGNITIONPRO_ID	0x2000
>  
> @@ -41,6 +42,7 @@ static void omninet_port_remove(struct usb_serial_port *port);
>  static const struct usb_device_id id_table[] = {
>  	{ USB_DEVICE(ZYXEL_VENDOR_ID, ZYXEL_OMNINET_ID) },
>  	{ USB_DEVICE(ZYXEL_VENDOR_ID, BT_IGNITIONPRO_ID) },
> +	{ USB_DEVICE(ZYXEL_VENDOR_ID, ZYXEL_OMNI_56K_PLUS_ID) },
>  	{ }						/* Terminating entry */
>  };
>  MODULE_DEVICE_TABLE(usb, id_table);

Now applied with a slightly modified commit message. Thanks.

Johan