lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 25 May 2021 09:03:26 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Alexandre GRIVEAUX <agriveaux@...tnet.info>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 2/2] USB: serial: omninet: Renaming driver to
 Zyxel omni.net

On Sun, May 23, 2021 at 06:35:22PM +0200, Alexandre GRIVEAUX wrote:
> With the inclusion of Omni 56K Plus, this driver seem to be more common
> among the family of Zyxel omni modem.

I amended the commit message to make it more clear that you're updating
the driver and module descriptions and not really renaming the driver.

> Signed-off-by: Alexandre GRIVEAUX <agriveaux@...tnet.info>
> ---
>  drivers/usb/serial/omninet.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
> index 8be91f5a4dd7..79c0dab46ae8 100644
> --- a/drivers/usb/serial/omninet.c
> +++ b/drivers/usb/serial/omninet.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * USB ZyXEL omni.net LCD PLUS driver
> + * USB ZyXEL omni.net driver
>   *
>   * Copyright (C) 2013,2017 Johan Hovold <johan@...nel.org>
>   *
> @@ -22,7 +22,7 @@
>  #include <linux/usb/serial.h>
>  
>  #define DRIVER_AUTHOR "Alessandro Zummo"
> -#define DRIVER_DESC "USB ZyXEL omni.net LCD PLUS Driver"
> +#define DRIVER_DESC "USB ZyXEL omni.net Driver"
>  
>  #define ZYXEL_VENDOR_ID		0x0586
>  #define ZYXEL_OMNINET_ID	0x1000
> @@ -52,7 +52,7 @@ static struct usb_serial_driver zyxel_omninet_device = {
>  		.owner =	THIS_MODULE,
>  		.name =		"omninet",
>  	},
> -	.description =		"ZyXEL - omni.net lcd plus usb",
> +	.description =		"ZyXEL - omni.net usb",
>  	.id_table =		id_table,
>  	.num_bulk_out =		2,
>  	.calc_num_ports =	omninet_calc_num_ports,

Now applied.

Johan

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ