linux-kernel - Re: [PATCH 2/2] net: phy: abort loading yt8511 driver in unsupported modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 May 2021 15:03:49 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Peter Geis <pgwipeout@...il.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 2/2] net: phy: abort loading yt8511 driver in unsupported
 modes

On Tue, May 25, 2021 at 08:26:15AM -0400, Peter Geis wrote:
> While investigating the clang `ge` uninitialized variable report, it was
> discovered the default switch would have unintended consequences. Due to
> the switch to __phy_modify, the driver would modify the ID values in the
> default scenario.
> 
> Fix this by promoting the interface mode switch and aborting when the
> mode is not a supported RGMII mode.
> 
> This prevents the `ge` and `fe` variables from ever being used
> uninitialized.
> 
> Fixes: b1b41c047f73 ("net: phy: add driver for Motorcomm yt8511 phy")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Peter Geis <pgwipeout@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew