linux-kernel - Re: [PATCH v4] tpm2: add longer timeout for verify signature command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YK3VDSiZvaSlca3C@kernel.org>
Date:   Wed, 26 May 2021 07:56:45 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     amirmizi6@...il.com
Cc:     Eyal.Cohen@...oton.com, peterhuewe@....de, jgg@...pe.ca,
        linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
        Dan.Morav@...oton.com, oren.tanami@...oton.com,
        shmulik.hager@...oton.com, amir.mizinski@...oton.com
Subject: Re: [PATCH v4] tpm2: add longer timeout for verify signature command

On Wed, May 26, 2021 at 07:50:43AM +0300, Jarkko Sakkinen wrote:
> On Tue, May 25, 2021 at 02:13:25PM +0300, amirmizi6@...il.com wrote:
> > From: Amir Mizinski <amirmizi6@...il.com>
> > 
> > While running a TPM2_CC_VERIFY_SIGNATURE operation with RSA 3072-bit
> > keys the TPM driver fails with the following error:
> > 
> > "kernel: [ 2416.187522] tpm tpm0: Operation Timed out"
> > 
> > Since the TPM PC Client specification does not specify a number for
> > verify signature operation timeout, and the duration of
> > TPM2_CC_VERIFY_SIGNATURE with RSA 3072-bit keys exceeds the current timeout
> > of TPM_LONG (2 seconds), it is preferable to pick the longest timeout
> > possible.
> > 
> > Therefore, set the duration for TPM2_CC_VERIFY_SIGNATUE to TPM_LONG_LONG
> > (5 minutes).
> > 
> > Link: https://trustedcomputinggroup.org/resource/pc-client-specific-platform-firmware-profile-specification/
> > Signed-off-by: Amir Mizinski <amirmizi6@...il.com>
> > ---
> 
> Thank you.
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@....fi>

I mean @kernel.org.

I mangled the short summary as 

"tpm: add longer timeout for TPM2_CC_VERIFY_SIGNATURE"

given that 

1. The subsystem tag was wrong.
2. Always to talk about the *exact thing*. I.e. in this case it's
   preferable to just write the command name, as"verify time signature
   command" does not have any formal menaing.

It's now applied, thanks.

/Jarkko